feat(ui5): Add UI Integration Cards Guidelines as Skills#51
Open
dimovpetar wants to merge 8 commits into
Open
Conversation
flovogt
changed the title
d3xter666
added a commit
that referenced
this pull request
May 15, 2026
Remove duplicate integration cards skill that is already provided by the MCP-based ui5 plugin (PR #51). This change eliminates duplication between the two plugin architectures and focuses the ui5-guidelines plugin on coding standards and TypeScript conversion. Changes: - Delete skills/ui5-integration-cards/ directory and all reference files - Update .claude-plugin/plugin.json to list only 2 skills - Remove 15 integration cards test cases from test-cases.ts - Update provider detectSkill() methods to remove integration cards patterns - Update cross-provider tests to use only remaining test cases - Remove integration cards sections from README.md and TESTING.md - Update test counts: 47 → 32 test cases per provider - Update triggering tests to reflect only 2 skills - All tests passing: 53/53 (100%)
d3xter666
reviewed
May 15, 2026
Member
d3xter666
left a comment
d3xter666
left a comment
There was a problem hiding this comment.
The skill file seems quite big and will overload the context of the agent.
Try running an agent harness optimizer, so that it will optimize the skill and create reference files, making the main skill file more concise
d3xter666
added a commit
that referenced
this pull request
May 15, 2026
…ingle skill Remove duplicate skills already provided by dedicated plugins in the repository: - ui5-typescript-expert (redundant with ui5-typescript-conversion plugin) - ui5-integration-cards (redundant with ui5 MCP plugin, PR #51) This change consolidates ui5-guidelines to focus exclusively on UI5 best practices and coding standards, eliminating duplication across the plugin ecosystem. Repository plugin analysis: - ui5 (MCP) - Tools for project creation, linting, API docs, Integration Cards - ui5-typescript-conversion - Dedicated TypeScript conversion (791 lines) - ui5-guidelines - NOW: Best practices only (was: 3 skills, now: 1 skill) Changes: - Delete skills/ui5-typescript-expert/ directory and all reference files (6 files) - Update .claude-plugin/plugin.json to list only ui5-best-practices - Remove description references to TypeScript and Integration Cards - Remove 12 TypeScript test cases from test-cases.ts (IDs 16-27) - Remove 9 TypeScript triggering tests from trigger-cases.json - Update provider detectSkill() to focus on best-practices patterns - Update cross-provider tests to use only remaining test cases - Update README.md with TypeScript conversion plugin reference - Update TESTING.md test counts: 32 → 20 test cases per provider - Update documentation with accurate test counts and coverage - All tests passing: 38/38 (100%) Test results: - Structure: 10/10 passing (100%) - Triggering: 26/26 passing (100%) - Performance: 2/2 passing (100%) Plugin now focused on single responsibility: UI5 best practices and coding standards. For TypeScript conversion, users should install ui5-typescript-conversion plugin. For Integration Cards, users should use ui5 MCP plugin.
d3xter666
added a commit
that referenced
this pull request
May 15, 2026
Remove duplicate integration cards skill that is already provided by the MCP-based ui5 plugin (PR #51). This change eliminates duplication between the two plugin architectures and focuses the ui5-guidelines plugin on coding standards and TypeScript conversion. Changes: - Delete skills/ui5-integration-cards/ directory and all reference files - Update .claude-plugin/plugin.json to list only 2 skills - Remove 15 integration cards test cases from test-cases.ts - Update provider detectSkill() methods to remove integration cards patterns - Update cross-provider tests to use only remaining test cases - Remove integration cards sections from README.md and TESTING.md - Update test counts: 47 → 32 test cases per provider - Update triggering tests to reflect only 2 skills - All tests passing: 53/53 (100%)
d3xter666
added a commit
that referenced
this pull request
May 15, 2026
…ingle skill Remove duplicate skills already provided by dedicated plugins in the repository: - ui5-typescript-expert (redundant with ui5-typescript-conversion plugin) - ui5-integration-cards (redundant with ui5 MCP plugin, PR #51) This change consolidates ui5-guidelines to focus exclusively on UI5 best practices and coding standards, eliminating duplication across the plugin ecosystem. Repository plugin analysis: - ui5 (MCP) - Tools for project creation, linting, API docs, Integration Cards - ui5-typescript-conversion - Dedicated TypeScript conversion (791 lines) - ui5-guidelines - NOW: Best practices only (was: 3 skills, now: 1 skill) Changes: - Delete skills/ui5-typescript-expert/ directory and all reference files (6 files) - Update .claude-plugin/plugin.json to list only ui5-best-practices - Remove description references to TypeScript and Integration Cards - Remove 12 TypeScript test cases from test-cases.ts (IDs 16-27) - Remove 9 TypeScript triggering tests from trigger-cases.json - Update provider detectSkill() to focus on best-practices patterns - Update cross-provider tests to use only remaining test cases - Update README.md with TypeScript conversion plugin reference - Update TESTING.md test counts: 32 → 20 test cases per provider - Update documentation with accurate test counts and coverage - All tests passing: 38/38 (100%) Test results: - Structure: 10/10 passing (100%) - Triggering: 26/26 passing (100%) - Performance: 2/2 passing (100%) Plugin now focused on single responsibility: UI5 best practices and coding standards. For TypeScript conversion, users should install ui5-typescript-conversion plugin. For Integration Cards, users should use ui5 MCP plugin.
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
Remove duplicate integration cards skill that is already provided by the MCP-based ui5 plugin (PR #51). This change eliminates duplication between the two plugin architectures and focuses the ui5-guidelines plugin on coding standards and TypeScript conversion. Changes: - Delete skills/ui5-integration-cards/ directory and all reference files - Update .claude-plugin/plugin.json to list only 2 skills - Remove 15 integration cards test cases from test-cases.ts - Update provider detectSkill() methods to remove integration cards patterns - Update cross-provider tests to use only remaining test cases - Remove integration cards sections from README.md and TESTING.md - Update test counts: 47 → 32 test cases per provider - Update triggering tests to reflect only 2 skills - All tests passing: 53/53 (100%)
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
…ingle skill Remove duplicate skills already provided by dedicated plugins in the repository: - ui5-typescript-expert (redundant with ui5-typescript-conversion plugin) - ui5-integration-cards (redundant with ui5 MCP plugin, PR #51) This change consolidates ui5-guidelines to focus exclusively on UI5 best practices and coding standards, eliminating duplication across the plugin ecosystem. Repository plugin analysis: - ui5 (MCP) - Tools for project creation, linting, API docs, Integration Cards - ui5-typescript-conversion - Dedicated TypeScript conversion (791 lines) - ui5-guidelines - NOW: Best practices only (was: 3 skills, now: 1 skill) Changes: - Delete skills/ui5-typescript-expert/ directory and all reference files (6 files) - Update .claude-plugin/plugin.json to list only ui5-best-practices - Remove description references to TypeScript and Integration Cards - Remove 12 TypeScript test cases from test-cases.ts (IDs 16-27) - Remove 9 TypeScript triggering tests from trigger-cases.json - Update provider detectSkill() to focus on best-practices patterns - Update cross-provider tests to use only remaining test cases - Update README.md with TypeScript conversion plugin reference - Update TESTING.md test counts: 32 → 20 test cases per provider - Update documentation with accurate test counts and coverage - All tests passing: 38/38 (100%) Test results: - Structure: 10/10 passing (100%) - Triggering: 26/26 passing (100%) - Performance: 2/2 passing (100%) Plugin now focused on single responsibility: UI5 best practices and coding standards. For TypeScript conversion, users should install ui5-typescript-conversion plugin. For Integration Cards, users should use ui5 MCP plugin.
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
Remove duplicate integration cards skill that is already provided by the MCP-based ui5 plugin (PR #51). This change eliminates duplication between the two plugin architectures and focuses the ui5-guidelines plugin on coding standards and TypeScript conversion. Changes: - Delete skills/ui5-integration-cards/ directory and all reference files - Update .claude-plugin/plugin.json to list only 2 skills - Remove 15 integration cards test cases from test-cases.ts - Update provider detectSkill() methods to remove integration cards patterns - Update cross-provider tests to use only remaining test cases - Remove integration cards sections from README.md and TESTING.md - Update test counts: 47 → 32 test cases per provider - Update triggering tests to reflect only 2 skills - All tests passing: 53/53 (100%)
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
…ingle skill Remove duplicate skills already provided by dedicated plugins in the repository: - ui5-typescript-expert (redundant with ui5-typescript-conversion plugin) - ui5-integration-cards (redundant with ui5 MCP plugin, PR #51) This change consolidates ui5-guidelines to focus exclusively on UI5 best practices and coding standards, eliminating duplication across the plugin ecosystem. Repository plugin analysis: - ui5 (MCP) - Tools for project creation, linting, API docs, Integration Cards - ui5-typescript-conversion - Dedicated TypeScript conversion (791 lines) - ui5-guidelines - NOW: Best practices only (was: 3 skills, now: 1 skill) Changes: - Delete skills/ui5-typescript-expert/ directory and all reference files (6 files) - Update .claude-plugin/plugin.json to list only ui5-best-practices - Remove description references to TypeScript and Integration Cards - Remove 12 TypeScript test cases from test-cases.ts (IDs 16-27) - Remove 9 TypeScript triggering tests from trigger-cases.json - Update provider detectSkill() to focus on best-practices patterns - Update cross-provider tests to use only remaining test cases - Update README.md with TypeScript conversion plugin reference - Update TESTING.md test counts: 32 → 20 test cases per provider - Update documentation with accurate test counts and coverage - All tests passing: 38/38 (100%) Test results: - Structure: 10/10 passing (100%) - Triggering: 26/26 passing (100%) - Performance: 2/2 passing (100%) Plugin now focused on single responsibility: UI5 best practices and coding standards. For TypeScript conversion, users should install ui5-typescript-conversion plugin. For Integration Cards, users should use ui5 MCP plugin.
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
Remove duplicate integration cards skill that is already provided by the MCP-based ui5 plugin (PR #51). This change eliminates duplication between the two plugin architectures and focuses the ui5-guidelines plugin on coding standards and TypeScript conversion. Changes: - Delete skills/ui5-integration-cards/ directory and all reference files - Update .claude-plugin/plugin.json to list only 2 skills - Remove 15 integration cards test cases from test-cases.ts - Update provider detectSkill() methods to remove integration cards patterns - Update cross-provider tests to use only remaining test cases - Remove integration cards sections from README.md and TESTING.md - Update test counts: 47 → 32 test cases per provider - Update triggering tests to reflect only 2 skills - All tests passing: 53/53 (100%)
d3xter666
added a commit
that referenced
this pull request
May 18, 2026
…ingle skill Remove duplicate skills already provided by dedicated plugins in the repository: - ui5-typescript-expert (redundant with ui5-typescript-conversion plugin) - ui5-integration-cards (redundant with ui5 MCP plugin, PR #51) This change consolidates ui5-guidelines to focus exclusively on UI5 best practices and coding standards, eliminating duplication across the plugin ecosystem. Repository plugin analysis: - ui5 (MCP) - Tools for project creation, linting, API docs, Integration Cards - ui5-typescript-conversion - Dedicated TypeScript conversion (791 lines) - ui5-guidelines - NOW: Best practices only (was: 3 skills, now: 1 skill) Changes: - Delete skills/ui5-typescript-expert/ directory and all reference files (6 files) - Update .claude-plugin/plugin.json to list only ui5-best-practices - Remove description references to TypeScript and Integration Cards - Remove 12 TypeScript test cases from test-cases.ts (IDs 16-27) - Remove 9 TypeScript triggering tests from trigger-cases.json - Update provider detectSkill() to focus on best-practices patterns - Update cross-provider tests to use only remaining test cases - Update README.md with TypeScript conversion plugin reference - Update TESTING.md test counts: 32 → 20 test cases per provider - Update documentation with accurate test counts and coverage - All tests passing: 38/38 (100%) Test results: - Structure: 10/10 passing (100%) - Triggering: 26/26 passing (100%) - Performance: 2/2 passing (100%) Plugin now focused on single responsibility: UI5 best practices and coding standards. For TypeScript conversion, users should install ui5-typescript-conversion plugin. For Integration Cards, users should use ui5 MCP plugin.
dimovpetar
force-pushed
the
feat/integration-cards-skill
branch
from
4ec4ad4 to
e225737
Compare
alexandar-mitsev
suggested changes
May 19, 2026
Editor field referenced parameters/CustomerID/value but the manifest declared "Customers" as an array, so the binding never matched. Use a singular "Customer" string key in both places.
alexandar-mitsev
suggested changes
May 19, 2026
flovogt
changed the title
- Fix analytical chart samples (bubble, time_bubble, stacked variants, bullet, waterfall, combinations) so feeds and measures match each chart type's requirements - Add GitHub samples link to the Card Explorer section - Require asking the user before making all manifest fields editable in the Configuration Editor - Clarify the donut/pie context on the feeds example in SKILL.md
Lead the skill description with the same imperative the UI5 MCP server's "Get Integration Cards Guidelines" tool uses, and enumerate the trigger surfaces (manifest.json, Configuration Editor, analytical charts), so Claude prefers loading the skill over calling the MCP tool.
…mple
The manifest defines header.icon.src as {parameters>/icon/value}, so the
editor should bind to the parameter path instead of the header path.
Otherwise the editor writes to a different manifest location than the
binding reads from.
Reduce word count from ~1058 to ~740 by restructuring prose into compact rules tables. Hoist reference-loading triggers to the top so agents load analytical_chart_types.md and configuration_editor_example.md before working on those areas. Replace section symbols with markdown anchor links, demote the Card Explorer reference to the bottom, and add a "No data to display" symptom callout pointing at the data-placement rule (the most common cause).
dimovpetar
force-pushed
the
feat/integration-cards-skill
branch
from
23b7ecf to
c34d265
Compare
alexandar-mitsev
suggested changes
May 21, 2026
Member
alexandar-mitsev
left a comment
alexandar-mitsev
left a comment
There was a problem hiding this comment.
- Fix the iconShape/iconBackground inconsistency in the Configuration Editor example (violates the stated "no invented fields" rule).
- Fix the missing color feed in timeseries_stacked_column (#11) and timeseries_100_stacked_column (#14) examples.
- Consider adding one sentence to Section 5 clarifying that manifestpath can reference direct manifest paths, not only configuration parameters.
| @@ -0,0 +1,103 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
claude:
Minor — iconShape and iconBackground are in the example but not in the manifest parameters
In configuration_editor_example.md, the Configuration Editor exposes iconShape (mapped to /sap.card/header/icon/shape) and iconBackground (mapped to
/sap.card/header/icon/backgroundColor), but neither of these paths exists in the corresponding manifest.json. This contradicts the rule stated in section
5: "No invented fields — Never add an editor field that does not exist in manifest.json." The example should either add these to manifest.json or remove
them from the editor, or add a note that these are editable direct manifest paths (not parameter bindings).
Minor — data indentation inconsistency in the example manifest
In configuration_editor_example.md, the sap.card/data block uses 8-space indentation while all other sections use 4-space. This is cosmetic but
distracting in a reference document.
Suggestion — Section 5 rule could be more precise about manifestpath for direct vs. parameter paths
The example shows two kinds of manifestpath values:
- /sap.card/configuration/parameters//value (for configuration parameters)
- /sap.card/header/icon/shape (direct manifest path, not a parameter)
Section 5 in SKILL.md doesn't mention this distinction. Adding a note that editor fields can map to either configuration parameters or direct manifest
paths would help an agent avoid mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding skills for UI Integration Cards development.
Heavily inspired by https://github.com/UI5/mcp-server/blob/main/resources/integration_cards_guidelines.md.
JIRA: BGSOFUIRODOPI-3670